From d8a5716a2269c82e1133b28e9330d1be3b4fe95b Mon Sep 17 00:00:00 2001
From: Baoshuo <i@baoshuo.ren>
Date: Fri, 24 Apr 2026 20:00:31 +0800
Subject: [PATCH] core: fix UserLoginHandler behavior when disabled builtin
 login (#1150)

---
 packages/hydrooj/src/handler/user.ts | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/packages/hydrooj/src/handler/user.ts b/packages/hydrooj/src/handler/user.ts
index 8dc635984..4b941de6e 100644
--- a/packages/hydrooj/src/handler/user.ts
+++ b/packages/hydrooj/src/handler/user.ts
@@ -45,12 +45,10 @@ async function successfulAuth(this: Handler, udoc: User) {
 
 class UserLoginHandler extends Handler {
     noCheckPermView = true;
-    async prepare() {
-        if (!system.get('server.login')) throw new BuiltinLoginError();
-    }
 
     async get() {
         this.response.template = 'user_login.html';
+        this.response.body.loginMethods = this.loginMethods;
     }
 
     @param('uname', Types.Username)
@@ -63,6 +61,7 @@ class UserLoginHandler extends Handler {
         domainId: string, uname: string, password: string, rememberme = false, redirect = '',
         tfa = '', authnChallenge = '',
     ) {
+        if (!system.get('server.login')) throw new BuiltinLoginError();
         let udoc = await user.getByEmail(domainId, uname);
         udoc ||= await user.getByUname(domainId, uname);
         if (!udoc) throw new UserNotFoundError(uname);