lgtm: fix alerts

packages/hydrooj/src/handler/home.ts

@@ -310,10 +310,11 @@ class HomeDomainCreateHandler extends Handler {
     @param('name', Types.Title)
     @param('bulletin', Types.Content)
     @param('avatar', Types.Content, true, isEmail)
+    // eslint-disable-next-line @typescript-eslint/no-shadow
     async post(_: string, id: string, name: string, bulletin: string, avatar: string) {
         const doc = await domain.get(id);
         if (doc) throw new DomainAlreadyExistsError(id);
-        avatar = avatar || this.user.avatar || `gravatar:${this.user.mail}` || 'gravatar:guest@hydro.local';
+        avatar = avatar || this.user.avatar || `gravatar:${this.user.mail}`;
         const domainId = await domain.add(id, this.user._id, name, bulletin);
         await domain.edit(domainId, { avatar });
         await domain.setUserRole(domainId, this.user._id, 'root');

packages/ui-default/build/main.js

@@ -71,7 +71,7 @@ async function runGulp() {
 async function main() {
   const dir = process.cwd();
   process.chdir(root());
-  await runGulp({});
+  await runGulp();
   await runWebpack(argv);
   process.chdir(dir);
 }

packages/ui-default/pages/problem_edit.page.js

@@ -62,7 +62,7 @@ function parseCategorySelection() {
     else if (!subcategory) {
       categories[category].select = true;
       dirtyCategories.push({ type: 'category', category });
-    } else if (category) {
+    } else {
       categories[category].children[subcategory].select = true;
       dirtyCategories.push({ type: 'subcategory', subcategory, category });
     }

packages/ui-default/tool/checkTranslation.js

@@ -25,8 +25,8 @@ function _(str, format) {
   if (!texts[str]) texts[str] = [currentFile];
   else texts[str].push(currentFile);
 }
-const i18n = _;
+const i18n = _; // lgtm [js/unused-local-variable]
-const Setting = _;
+const Setting = _; // lgtm [js/unused-local-variable]
 
 function scanTemplate(folder, relative = 'templates') {
   const files = fs.readdirSync(folder);

packages/utils/lib/utils.ts

@@ -1,4 +1,4 @@
-import path, { sep } from 'path';
+import path from 'path';
 import fs from 'fs-extra';
 import os from 'os';
 import { Duplex } from 'stream';