core: fix share

packages/hydrooj/package.json

@@ -1,6 +1,6 @@
 {
     "name": "hydrooj",
-    "version": "3.1.17",
+    "version": "3.1.18",
     "bin": "bin/hydrooj.js",
     "main": "src/loader",
     "module": "src/loader",

packages/hydrooj/src/handler/problem.ts

@@ -187,6 +187,8 @@ export class ProblemMainHandler extends ProblemHandler {
     @param('pids', Types.NumericArray)
     @param('target', Types.String)
     async postCopy(domainId: string, pids: number[], target: string) {
+        const t = `,${this.domain.share || ''},`;
+        if (t !== ',*,' && !t.includes(`,${target},`)) throw new PermissionError(target);
         const ddoc = await domain.get(target);
         if (!ddoc) throw new NotFoundError(target);
         const dudoc = await user.getById(target, this.user._id);
@@ -346,6 +348,8 @@ export class ProblemDetailHandler extends ProblemHandler {
 
     @param('target', Types.String)
     async postCopy(domainId: string, target: string) {
+        const t = `,${this.domain.share || ''},`;
+        if (t !== ',*,' && !t.includes(`,${target},`)) throw new PermissionError(target);
         const ddoc = await domain.get(target);
         if (!ddoc) throw new NotFoundError(target);
         const dudoc = await user.getById(target, this.user._id);

packages/ui-default/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hydrooj/ui-default",
-  "version": "4.26.9",
+  "version": "4.26.10",
   "author": "undefined <i@undefined.moe>",
   "license": "AGPL-3.0",
   "main": "hydro.js",

packages/ui-default/templates/partials/problem_list.html

@@ -8,10 +8,8 @@
 {% else %}
   <table class="data-table">
     <colgroup>
-    {% if handler.user.hasPerm(perm.PERM_EDIT_PROBLEM) %}
       <col class="col--checkbox display-mode-hide">
       <col class="col--pid display-mode-hide">
-    {% endif %}
     {% if handler.user.hasPriv(PRIV.PRIV_USER_PROFILE) %}
       <col class="col--status edit-mode-hide">
     {% endif %}
@@ -22,14 +20,12 @@
     </colgroup>
     <thead>
       <tr>
-        {% if handler.user.hasPerm(perm.PERM_EDIT_PROBLEM) %}
         <th class="col--checkbox display-mode-hide">
           <label class="compact checkbox">
             <input type="checkbox" name="select_all" data-checkbox-toggle="problem">
           </label>
         </th>
         <th class="col--pid display-mode-hide">{{ _('ID') }}</th>
-        {% endif %}
         {% if handler.user.hasPriv(PRIV.PRIV_USER_PROFILE) %}
           <th class="col--status record-status--border edit-mode-hide">{{ _('Status') }}</th>
         {% endif %}
@@ -43,14 +39,12 @@
       {%- for pdoc in pdocs -%}
       {% set psdoc = psdict[pdoc['docId']] %}
       <tr data-pid="{{ pdoc.docId }}">
-        {% if handler.user.hasPerm(perm.PERM_EDIT_PROBLEM) %}
         <td class="col--checkbox display-mode-hide">
           <label class="compact checkbox">
             <input type="checkbox" data-checkbox-group="problem" data-checkbox-range>
           </label>
         </td>
         <td class="col--pid display-mode-hide">{{ pdoc.docId }}</td>
-        {% endif %}
         {% if handler.user.hasPriv(PRIV.PRIV_USER_PROFILE) %}
           {% if psdoc['rid'] %}
             {{ record.render_status_td(psdoc, rid_key='rid', class="edit-mode-hide") }}