Hello airbnb

hydro/model/user.js

@@ -1,11 +1,11 @@
-const
-    system = require('./system'),
-    { UserNotFoundError, UserAlreadyExistError } = require('../error'),
-    pwhash = require('../lib/pwhash'),
-    validator = require('../lib/validator'),
-    db = require('../service/db'),
-    coll = db.collection('user'),
-    coll_role = db.collection('role');
+const system = require('./system');
+const { UserNotFoundError, UserAlreadyExistError } = require('../error');
+const pwhash = require('../lib/pwhash');
+const validator = require('../lib/validator');
+const db = require('../service/db');
+
+const coll = db.collection('user');
+const collRole = db.collection('role');
 
 class USER {
     constructor(user) {
@@ -24,75 +24,78 @@ class USER {
         this.nAccept = user.nAccept || 0;
         this.nSubmit = user.nSubmit || 0;
     }
+
     hasPerm(perm) {
-        return this.perm == '-' || (this.perm || '').includes(perm);
+        return this.perm === '-' || (this.perm || '').includes(perm);
     }
+
     checkPassword(password) {
         return pwhash.check(password, this.salt, this.hash);
     }
 }
 async function getById(_id) {
-    let udoc = await coll.findOne({ _id });
+    const udoc = await coll.findOne({ _id });
     if (!udoc) throw new UserNotFoundError(_id);
-    let role = await coll_role.findOne({ _id: udoc.role || 'default' });
+    const role = await collRole.findOne({ _id: udoc.role || 'default' });
     udoc.perm = role.perm;
     return new USER(udoc);
 }
 async function getList(uids) {
-    let r = {};
-    for (let uid of uids)
-        r[uid] = await getById(uid);
+    const r = {};
+    for (const uid of uids) r[uid] = await getById(uid); // eslint-disable-line no-await-in-loop
     return r;
 }
 async function getByUname(uname) {
-    let unameLower = uname.trim().toLowerCase();
-    let udoc = await coll.findOne({ unameLower });
+    const unameLower = uname.trim().toLowerCase();
+    const udoc = await coll.findOne({ unameLower });
     if (!udoc) throw new UserNotFoundError(uname);
-    let role = await coll_role.findOne({ _id: udoc.role || 'default' });
+    const role = await collRole.findOne({ _id: udoc.role || 'default' });
     udoc.perm = role.perm;
     return new USER(udoc);
 }
 async function getByEmail(mail, ignoreMissing = false) {
-    let mailLower = mail.trim().toLowerCase();
-    let udoc = await coll.findOne({ mailLower });
+    const mailLower = mail.trim().toLowerCase();
+    const udoc = await coll.findOne({ mailLower });
     if (!udoc) {
         if (ignoreMissing) return null;
-        else throw new UserNotFoundError(mail);
+        throw new UserNotFoundError(mail);
     }
-    let role = await coll_role.findOne({ _id: udoc.role || 'default' });
+    const role = await collRole.findOne({ _id: udoc.role || 'default' });
     udoc.perm = role.perm;
     return new USER(udoc);
 }
-async function setPassword(uid, password) {
+function setPassword(uid, password) {
     validator.checkPassword(password);
-    let salt = pwhash.salt();
-    return await coll.findOneAndUpdate({ _id: uid }, {
-        $set: { salt, hash: pwhash.hash(password, salt) }
+    const salt = pwhash.salt();
+    return coll.findOneAndUpdate({ _id: uid }, {
+        $set: { salt, hash: pwhash.hash(password, salt) },
     });
 }
-async function setEmail(uid, mail) {
-    validator.checkEmail(mail);
-    return await setById(uid, { mail, mailLower: mail.trim().toLowerCase() });
-}
 function setById(uid, args) {
     coll.findOneAndUpdate({ _id: uid }, { $set: args });
 }
+function setEmail(uid, mail) {
+    validator.checkEmail(mail);
+    return setById(uid, { mail, mailLower: mail.trim().toLowerCase() });
+}
 async function changePassword(uid, currentPassword, newPassword) {
     validator.checkPassword(newPassword);
-    let udoc = await getById(uid);
+    const udoc = await getById(uid);
     udoc.checkPassword(currentPassword);
-    let salt = pwhash.salt();
+    const salt = pwhash.salt();
     return await coll.findOneAndUpdate({
-        _id: udoc._id
+        _id: udoc._id,
     }, {
-        $set: { salt, hash: pwhash.hash(newPassword, salt) }
+        $set: { salt, hash: pwhash.hash(newPassword, salt) },
     });
 }
-async function create({ uid, mail, uname, password, regip = '127.0.0.1', role = 'default' }) {
+async function create({
+    uid, mail, uname, password, regip = '127.0.0.1', role = 'default',
+}) {
     validator.checkUname(uname);
     validator.checkPassword(password);
     validator.checkEmail(mail);
-    let salt = pwhash.salt();
+    const salt = pwhash.salt();
     if (!uid) uid = system.incUserCounter();
     try {
         await coll.insertOne({
@@ -108,10 +111,10 @@ async function create({ uid, mail, uname, password, regip = '127.0.0.1', role =
             loginat: new Date(),
             loginip: regip,
             role,
-            gravatar: mail
+            gravatar: mail,
         });
     } catch (e) {
-        throw new UserAlreadyExistError([uid, uname, email]);
+        throw new UserAlreadyExistError([uid, uname, mail]);
     }
 }
 
@@ -120,8 +123,14 @@ function getMany(params) {
 }
 
 module.exports = {
-    changePassword, create, getByEmail,
-    getById, getByUname, getMany,
-    setById, setEmail,
-    setPassword, getList
-};
+    changePassword,
+    create,
+    getByEmail,
+    getById,
+    getByUname,
+    getMany,
+    setById,
+    setEmail,
+    setPassword,
+    getList,
+};