core: limit ViewRecord

packages/hydrooj/locales/ko.yaml

@@ -546,7 +546,6 @@ Rank: 순위
 ranking: 순위
 Read data of own problems: 자신의 문제 데이터 읽기
 Read data of problem: 문제 데이터 읽기
-Read record codes: 점수 읽기
 Ready (☆▽☆): 준비 완료! (☆▽☆)
 Ready: 준비됨
 Recent {0} Records: 최근 {0} 점수

packages/hydrooj/locales/zh.yaml

@@ -603,7 +603,7 @@ Recalculates nSubmit and nAccept in problem status.: 重新计算每道题目的
 Recommended: 推荐
 Record {0} not found.: 记录 {0} 不存在。
 record_detail: 记录详情
-record_main: 评测队列
+record_main: 评测记录
 Records per page: 每页展示的评测记录数量
 Records: 评测记录
 Refresh Records: 刷新评测记录

packages/hydrooj/locales/zh_TW.yaml

@@ -351,9 +351,9 @@ QQ Group: QQ 群
 QQ Visibility: QQ 可見性
 Quit Scratchpad: 退出線上程式設計模式
 Rank: 排名
+Read all records: 讀取記錄
 Read data of own problems: 讀取自己題目的資料
 Read data of problem: 讀取題目資料
-Read record codes: 讀取記錄的程式碼
 Ready (☆▽☆): 馬上開始 (☆▽☆)
 Ready: 即將開始
 Recent {0} Records: 最近 {0} 條記錄

packages/hydrooj/package.json

@@ -1,6 +1,6 @@
 {
     "name": "hydrooj",
-    "version": "2.31.2",
+    "version": "2.32.0",
     "bin": "bin/hydrooj.js",
     "main": "src/loader",
     "module": "src/loader",

packages/hydrooj/src/handler/contest.ts

@@ -386,11 +386,11 @@ export class ContestDetailProblemSubmitHandler extends ContestProblemHandler {
 export class ContestCodeHandler extends Handler {
     @param('tid', Types.ObjectID)
     async get(domainId: string, tid: ObjectID) {
-        if (!this.user.hasPriv(PRIV.PRIV_READ_RECORD_CODE)) {
+        await this.limitRate('contest_code', 3600, 60);
-            this.checkPerm(PERM.PERM_READ_RECORD_CODE);
-        }
-        await this.limitRate('homework_code', 3600, 60);
         const [tdoc, tsdocs] = await contest.getAndListStatus(domainId, tid);
+        if (!this.user.own(tdoc) && !this.user.hasPriv(PRIV.PRIV_READ_RECORD)) {
+            this.checkPerm(PERM.PERM_READ_RECORD);
+        }
         if (!contest.canShowRecord.call(this, tdoc as any, true)) {
             throw new PermissionError(PERM.PERM_VIEW_CONTEST_HIDDEN_SCOREBOARD);
         }

packages/hydrooj/src/handler/homework.ts

@@ -389,11 +389,13 @@ class HomeworkScoreboardDownloadHandler extends Handler {
 class HomeworkCodeHandler extends Handler {
     @param('tid', Types.ObjectID)
     async get(domainId: string, tid: ObjectID) {
-        if (!this.user.hasPriv(PRIV.PRIV_READ_RECORD_CODE)) this.checkPerm(PERM.PERM_READ_RECORD_CODE);
+        await this.limitRate('contest_code', 3600, 60);
-        await this.limitRate('homework_code', 3600, 60);
         const [tdoc, tsdocs] = await contest.getAndListStatus(
             domainId, tid, document.TYPE_HOMEWORK,
         );
+        if (!this.user.own(tdoc) && !this.user.hasPriv(PRIV.PRIV_READ_RECORD)) {
+            this.checkPerm(PERM.PERM_READ_RECORD);
+        }
         const rnames = {};
         for (const tsdoc of tsdocs) {
             for (const pid in tsdoc.detail || {}) {

packages/hydrooj/src/handler/record.ts

@@ -104,8 +104,8 @@ class RecordDetailHandler extends Handler {
                 throw new PermissionError(rid);
             }
         }
-        if (rdoc.uid !== this.user._id && !this.user.hasPriv(PRIV.PRIV_READ_RECORD_CODE)) {
+        if (rdoc.uid !== this.user._id && !this.user.hasPriv(PRIV.PRIV_READ_RECORD)) {
-            if (!this.user.hasPerm(PERM.PERM_READ_RECORD_CODE)) rdoc.code = null;
+            this.checkPerm(PERM.PERM_READ_RECORD);
         }
         // eslint-disable-next-line prefer-const
         let [pdoc, udoc] = await Promise.all([
@@ -188,7 +188,10 @@ class RecordMainConnectionHandler extends ConnectionHandler {
             if (pretest || contest.canShowScoreboard.call(this, tdoc, true)) this.tid = tid.toHexString();
             else throw new PermissionError(PERM.PERM_VIEW_CONTEST_HIDDEN_SCOREBOARD);
         }
-        if (uidOrName) {
+        if (pretest) {
+            this.pretest = true;
+            this.uid = this.user._id;
+        } else if (uidOrName) {
             let udoc = await user.getById(domainId, +uidOrName);
             if (udoc) this.uid = udoc._id;
             else {
@@ -207,7 +210,6 @@ class RecordMainConnectionHandler extends ConnectionHandler {
             } else throw new ProblemNotFoundError(domainId, pid);
         }
         if (status) this.status = status;
-        if (pretest) this.pretest = true;
         this.dispose = bus.on('record/change', this.onRecordChange.bind(this));
     }
 
@@ -261,6 +263,9 @@ class RecordDetailConnectionHandler extends ConnectionHandler {
             const tdoc = await contest.get(domainId, rdoc.contest.tid, -1);
             if (!contest.canShowRecord.call(this, tdoc)) throw new PermissionError(PERM.PERM_VIEW_CONTEST_HIDDEN_SCOREBOARD);
         }
+        if (rdoc.uid !== this.user._id && !this.user.hasPriv(PRIV.PRIV_READ_RECORD)) {
+            this.checkPerm(PERM.PERM_READ_RECORD);
+        }
         this.rid = rid.toString();
         this.dispose = bus.on('record/change', this.onRecordChange.bind(this));
         this.onRecordChange(rdoc);

packages/hydrooj/src/lib/ui.ts

@@ -34,16 +34,18 @@ const buildChecker = (...permPrivChecker: Array<number | bigint | Function>) =>
 };
 
 export const Nav = (
-    name: string, args: Dictionary<any> = {}, prefix: string,
+    name: string, args: ((handler: any) => Record<string, any>) | Record<string, any> = {}, prefix: string,
     ...permPrivChecker: Array<number | bigint | Function>
 ) => {
+    if (typeof args !== 'function') args = () => (args || {});
+    const checker = buildChecker(...permPrivChecker);
     if (name.startsWith('@@')) {
         global.Hydro.ui.nodes.nav.splice(+name.split('@@')[1], 0, {
-            name: name.split('@@')[2], args: args || {}, prefix, checker: buildChecker(...permPrivChecker),
+            name: name.split('@@')[2], args, prefix, checker,
         });
     } else {
         global.Hydro.ui.nodes.nav.push({
-            name, args: args || {}, prefix, checker: buildChecker(...permPrivChecker),
+            name, args, prefix, checker,
         });
     }
 };
@@ -70,7 +72,7 @@ Nav('training_main', {}, 'training', PERM.PERM_VIEW_TRAINING);
 Nav('homework_main', {}, 'homework', PERM.PERM_VIEW_HOMEWORK);
 Nav('discussion_main', {}, 'discussion', PERM.PERM_VIEW_DISCUSSION);
 Nav('contest_main', {}, 'contest', PERM.PERM_VIEW_CONTEST);
-Nav('record_main', {}, 'record');
+Nav('record_main', (handler) => (handler.user.hasPriv(PRIV.PRIV_USER_PROFILE) ? { query: { uidOrName: handler.user._id } } : {}), 'record');
 Nav('ranking', {}, 'ranking', PERM.PERM_VIEW_RANKING);
 Nav('domain_dashboard', {}, 'domain', PERM.PERM_EDIT_DOMAIN);
 Nav('manage_dashboard', {}, 'manage', PRIV.PRIV_EDIT_SYSTEM);

packages/hydrooj/src/model/builtin.ts

@@ -30,7 +30,7 @@ export const PERM = {
     PERM_VIEW_PROBLEM_HIDDEN: 1n << 8n,
     PERM_SUBMIT_PROBLEM: 1n << 9n,
     PERM_READ_PROBLEM_DATA: 1n << 10n,
-    PERM_READ_RECORD_CODE: 1n << 12n,
+    PERM_READ_RECORD: 1n << 12n,
     PERM_REJUDGE_PROBLEM: 1n << 13n,
     PERM_REJUDGE: 1n << 14n,
 
@@ -113,7 +113,7 @@ export const PERMS = [
     Permission('perm_problem', PERM.PERM_VIEW_PROBLEM_HIDDEN, 'View hidden problems'),
     Permission('perm_problem', PERM.PERM_SUBMIT_PROBLEM, 'Submit problem'),
     Permission('perm_problem', PERM.PERM_READ_PROBLEM_DATA, 'Read data of problem'),
-    Permission('perm_record', PERM.PERM_READ_RECORD_CODE, 'Read record codes'),
+    Permission('perm_record', PERM.PERM_READ_RECORD, 'Read all records'),
     Permission('perm_record', PERM.PERM_REJUDGE_PROBLEM, 'Rejudge problems'),
     Permission('perm_record', PERM.PERM_REJUDGE, 'Rejudge records'),
     Permission('perm_problem_solution', PERM.PERM_VIEW_PROBLEM_SOLUTION, 'View problem solutions'),
@@ -232,7 +232,7 @@ export const PRIV = {
     PRIV_USER_PROFILE: 1 << 2,
     PRIV_REGISTER_USER: 1 << 3,
     PRIV_READ_PROBLEM_DATA: 1 << 4,
-    PRIV_READ_RECORD_CODE: 1 << 7,
+    PRIV_READ_RECORD: 1 << 7,
     PRIV_VIEW_HIDDEN_RECORD: 1 << 8,
     PRIV_JUDGE: 1 << 9, // (renamed)
     PRIV_CREATE_DOMAIN: 1 << 10,

packages/ui-default/components/zipDownloader/index.js

@@ -1,5 +1,5 @@
 import { dump } from 'js-yaml';
-import * as streamsaver from 'streamsaver';
+import streamsaver from 'streamsaver';
 import { createZipStream } from 'vj/utils/zip';
 import pipeStream from 'vj/utils/pipeStream';
 import i18n from 'vj/utils/i18n';

packages/ui-default/locales/ko.yaml

@@ -550,7 +550,6 @@ Rank: 순위
 ranking: 순위
 Read data of own problems: 자신의 문제 데이터 읽기
 Read data of problem: 문제 데이터 읽기
-Read record codes: 점수 읽기
 Ready (☆▽☆): 준비 완료! (☆▽☆)
 Ready: 준비됨
 Recent {0} Records: 최근 {0} 점수

packages/ui-default/locales/zh.yaml

@@ -584,9 +584,9 @@ Quit Scratchpad: 退出在线编程模式
 Quote: 引用
 Rank: 排名
 ranking: 排名
+Read all records: 读取所有提交记录
 Read data of own problems: 读取自己题目的数据
 Read data of problem: 读取题目数据
-Read record codes: 读取记录的代码
 Ready (☆▽☆): 马上开始 (☆▽☆)
 Ready: 即将开始
 Recent {0} Records: 最近 {0} 条记录
@@ -597,7 +597,7 @@ Recently Created Discussions: 最近创建的讨论
 Recommended: 推荐
 Record {0} not found.: 记录 {0} 不存在。
 record_detail: 记录详情
-record_main: 评测队列
+record_main: 评测记录
 Records: 评测记录
 Refresh Records: 刷新评测记录
 Refresh: 刷新

packages/ui-default/locales/zh_TW.yaml

@@ -353,9 +353,9 @@ QQ Group: QQ 群
 QQ Visibility: QQ 可見性
 Quit Scratchpad: 退出線上程式設計模式
 Rank: 排名
+Read all records: 讀取記錄
 Read data of own problems: 讀取自己題目的資料
 Read data of problem: 讀取題目資料
-Read record codes: 讀取記錄的程式碼
 Ready (☆▽☆): 馬上開始 (☆▽☆)
 Ready: 即將開始
 Recent {0} Records: 最近 {0} 條記錄

packages/ui-default/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hydrooj/ui-default",
-  "version": "4.14.15",
+  "version": "4.15.0",
   "author": "undefined <i@undefined.moe>",
   "license": "AGPL-3.0",
   "main": "hydro.js",

packages/ui-default/templates/partials/contest_sidebar.html

@@ -73,7 +73,7 @@
         <span class="icon icon-edit"></span> {{ _('Edit Contest') }}
       </a></li>
     {% endif %}
-    {% if handler.user.hasPriv(PRIV.PRIV_READ_RECORD_CODE) or handler.user.hasPerm(perm.PERM_READ_RECORD_CODE) %}
+    {% if handler.user.own(tdoc) or handler.user.hasPriv(PRIV.PRIV_READ_RECORD) or handler.user.hasPerm(perm.PERM_READ_RECORD) %}
       {% if model.contest.canShowRecord.call(handler, tdoc, true) %}
         <li class="menu__item"><a class="menu__link" href="{{ url('contest_code', tid=tdoc.docId) }}">
           <span class="icon icon-download"></span> {{ _('Export All Code') }}

packages/ui-default/templates/partials/homework_sidebar.html

@@ -57,7 +57,7 @@
         <span class="icon icon-edit"></span> {{ _('Edit Homework') }}
       </a></li>
     {% endif %}
-    {% if handler.user.hasPriv(PRIV.PRIV_READ_RECORD_CODE) or handler.user.hasPerm(perm.PERM_READ_RECORD_CODE) %}
+    {% if handler.user.own(tdoc) or handler.user.hasPriv(PRIV.PRIV_READ_RECORD) or handler.user.hasPerm(perm.PERM_READ_RECORD) %}
       <li class="menu__item"><a class="menu__link" href="{{ url('homework_code', tid=tdoc.docId) }}">
         <span class="icon icon-download"></span> {{ _('Export All Code') }}
       </a></li>

packages/ui-default/templates/partials/nav.html

@@ -11,7 +11,7 @@
     <ol class="nav__list nav__list--main clearfix">
       <li class="nav__list-item"><a href="/" class="nav__logo" style="background-size: 100% 100%;">&nbsp;</a></li>
       {%- for item in ui.nodes.nav -%}{% if item.checker(handler) %}
-          {{ nav_item(item.name, item.args, item.prefix) }}
+        {{ nav_item(item.name, item.args(handler), item.prefix) }}
       {% endif %}{%- endfor -%}
     </ol>
     <ol class="nav__list nav__list--secondary clearfix">