bug fixes & improments

packages/elastic/index.ts

@@ -31,7 +31,7 @@ export default class ElasticSearchService extends Service {
         this.client = new Client({ node: config.url });
     }
 
-    async problemSearch(domainId: string, q: string, opts): ReturnType<ProblemSearch> {
+    async problemSearch(domainId: string, q: string, opts: Parameters<ProblemSearch>[2] = {}): ReturnType<ProblemSearch> {
         const size = opts?.limit || SystemModel.get('pagination.problem');
         const from = Math.min(this.config.indexSize - size, opts?.skip || 0);
         const res = await this.client.search({

packages/hydrooj/src/handler/discussion.ts

@@ -72,7 +72,7 @@ class DiscussionMainHandler extends Handler {
         const parentType = { $in: Object.keys(typeMapper).map((i) => typeMapper[i]) };
         all &&= this.user.hasPerm(PERM.PERM_MOD_BADGE);
         const [ddocs, dpcount] = await this.paginate(
-            discussion.getMulti(domainId, { parentType, ...all ? {} : { hidden: false } }),
+            discussion.getMulti(domainId, { parentType, ...all ? {} : { hidden: false } }).hint('discussionSort'),
             page,
             'discussion',
         );

packages/hydrooj/src/handler/home.ts

@@ -507,6 +507,8 @@ class HomeDomainHandler extends Handler {
 
     @param('id', Types.String)
     async postLeave({ }, id: string) {
+        const ddoc = await domain.get(id);
+        if (!ddoc) throw new NotFoundError(id);
         await domain.setJoin(id, this.user._id, false);
         this.back();
     }

packages/hydrooj/src/loader.ts

@@ -46,7 +46,6 @@ if (process.env.NIX_PROFILES) {
 
 export class Loader extends Service {
     public state: Record<string, EffectScope> = Object.create(null);
-    public config: {};
     public suspend = false;
     public cache: Record<string, string> = Object.create(null);
     // public warnings: Record<string, string> = Object.create(null);

packages/hydrooj/src/model/document.ts

@@ -220,7 +220,7 @@ export async function deleteSub<T extends keyof DocType, K extends ArrayKeys<Doc
     domainId: string, docType: T, docId: DocType[T]['docId'],
     key: K, subId: MaybeArray<DocType[T][K][0]['_id']>,
 ): Promise<DocType[T]> {
-    subId = (subId instanceof Array) ? subId : [subId];
+    subId = Array.isArray(subId) ? subId : [subId];
     return await coll.findOneAndUpdate(
         { domainId, docType, docId },
         // @ts-ignore
@@ -416,6 +416,7 @@ export async function apply(ctx: Context) {
         collStatus.deleteMany({ domainId }),
     ]));
     await db.clearIndexes(coll, ['tag', 'hidden']);
+    const onlyFor = (docType: number) => ({ partialFilterExpression: { docType } });
     await db.ensureIndexes(
         coll,
         { key: { domainId: 1, docType: 1, docId: 1 }, name: 'basic', unique: true },
@@ -426,8 +427,8 @@ export async function apply(ctx: Context) {
         // For problem solution
         { key: { domainId: 1, docType: 1, parentType: 1, parentId: 1, vote: -1, docId: -1 }, name: 'solution', sparse: true },
         // For discussion
-        { key: { domainId: 1, docType: 1, pin: -1, docId: -1 }, name: 'discussionSort', sparse: true },
-        { key: { domainId: 1, docType: 1, parentType: 1, parentId: 1, pin: -1, docId: -1 }, name: 'discussionNodeSort', sparse: true },
+        { key: { docType: 1, domainId: 1, hidden: 1, pin: -1, docId: -1 }, name: 'discussionSort', ...onlyFor(TYPE_DISCUSSION) },
+        { key: { docType: 1, domainId: 1, hidden: 1, parentType: 1, parentId: 1, pin: -1, docId: -1 }, name: 'discussionNodeSort', sparse: true },
         // Hidden doc
         { key: { domainId: 1, docType: 1, hidden: 1, docId: -1 }, name: 'hiddenDoc', sparse: true },
         // For contest

packages/hydrooj/src/model/domain.ts

@@ -302,7 +302,7 @@ export async function apply(ctx: Context) {
     ctx.on('domain/delete-cache', async (domainId: string) => {
         const ddoc = await DomainModel.get(domainId);
         if (!ddoc) return;
-        for (const host of ddoc.hosts || []) {
+        for (const host of ddoc.host || []) {
             cache.delete(`host::${host}`);
         }
         cache.delete(`id::${domainId}`);

packages/scoreboard-xcpcio/package.json

@@ -7,6 +7,6 @@
         "postinstall": "node -r @hydrooj/register install.ts"
     },
     "dependencies": {
-        "@xcpcio/board-app": "^0.53.2"
+        "@xcpcio/board-app": "^0.54.0"
     }
 }

packages/ui-default/package.json

@@ -7,9 +7,6 @@
   "types": "api.ts",
   "repository": "https://github.com/hydro-dev/Hydro.git",
   "preferUnplugged": true,
-  "scripts": {
-    "lint": "eslint"
-  },
   "hydro": {
     "cli": false
   },
@@ -25,7 +22,7 @@
     "@fontsource/source-code-pro": "^5.2.5",
     "@fontsource/ubuntu-mono": "^5.2.5",
     "@hydrooj/utils": "workspace:^",
-    "@sentry/browser": "^9.7.0",
+    "@sentry/browser": "^9.8.0",
     "@sentry/webpack-plugin": "^3.2.2",
     "@simplewebauthn/browser": "13.1.0",
     "@svgr/webpack": "^8.1.0",
@@ -70,7 +67,7 @@
     "jquery.easing": "^1.4.1",
     "jquery.transit": "^0.9.12",
     "matchmedia-polyfill": "^0.3.2",
-    "md-editor-rt": "^5.4.2",
+    "md-editor-rt": "^5.4.3",
     "mini-css-extract-plugin": "^2.9.2",
     "moment": "^2.30.1",
     "monaco-editor": "0.52.2",

packages/ui-next/package.json

@@ -13,11 +13,9 @@
     "react-dom": "^18.3.1"
   },
   "devDependencies": {
-    "@eslint/js": "^9.22.0",
     "@types/react": "^19.0.12",
     "@types/react-dom": "^19.0.4",
     "@vitejs/plugin-react-swc": "^3.8.1",
-    "typescript": "~5.8.2",
     "vite": "^6.2.2"
   }
 }