core&ui: bug fixes

packages/hydrooj/src/entry/worker.ts

@@ -70,10 +70,12 @@ export async function apply(ctx: Context) {
     if (process.env.NODE_APP_INSTANCE === '0') {
         const staticDir = path.join(os.homedir(), '.hydro/static');
         await fs.emptyDir(staticDir);
-        await Promise.all(Object.values(global.addons).map(async (f) => {
+        // Use ordered copy to allow resource override
+        for (const f of Object.values(global.addons)) {
             const dir = path.join(f, 'public');
+            // eslint-disable-next-line no-await-in-loop
             if (await fs.pathExists(dir)) await fs.copy(dir, staticDir);
-        }));
+        }
         await new Promise((resolve, reject) => {
             ctx.inject(['migration'], async (c) => {
                 c.migration.registerChannel('hydrooj', require('../upgrade').coreScripts);

packages/hydrooj/src/handler/contest.ts

@@ -211,7 +211,7 @@ export class ContestProblemListHandler extends ContestDetailBaseHandler {
         if (contest.isDone(this.tdoc) && canViewRecord) {
             const correction = await problem.getListStatus(domainId, this.user._id, this.tdoc.pids);
             for (const pid in correction) {
-                if (this.tsdoc.detail[pid]?.rid === correction[pid].rid) delete correction[pid];
+                if (this.tsdoc.detail?.[pid]?.rid === correction[pid].rid) delete correction[pid];
             }
             rids.push(...Object.values(correction).map((i) => i.rid));
             this.response.body.correction = correction;

packages/hydrooj/src/handler/misc.ts

@@ -43,12 +43,11 @@ export class FilesHandler extends Handler {
         }
     }
 
-    @param('uid', Types.Int, true)
-    async get({ }, uid: number) {
+    async get({ }) {
         if (!this.udoc._files?.length) this.checkPriv(PRIV.PRIV_CREATE_FILE);
         this.response.body = {
             files: sortFiles(this.udoc._files),
-            urlForFile: (filename: string) => this.url('fs_download', { uid, filename }),
+            urlForFile: (filename: string) => this.url('fs_download', { uid: this.udoc._id, filename }),
         };
         this.response.pjax = 'partials/files.html';
         this.response.template = 'home_files.html';