From 1b11e6bcbb84ed4473eee4151f934f492ef86081 Mon Sep 17 00:00:00 2001
From: undefined <i@undefined.moe>
Date: Thu, 10 Feb 2022 18:08:33 +0800
Subject: [PATCH] ui: fix "select node to create discussion" hint

---
 packages/ui-default/package.json               |  2 +-
 .../templates/discussion_main_or_node.html     | 18 +++++++++---------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/packages/ui-default/package.json b/packages/ui-default/package.json
index 8ff743fbc..06d5be3f4 100644
--- a/packages/ui-default/package.json
+++ b/packages/ui-default/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@hydrooj/ui-default",
-  "version": "4.31.11",
+  "version": "4.31.12",
   "author": "undefined <i@undefined.moe>",
   "license": "AGPL-3.0",
   "main": "hydro.js",
diff --git a/packages/ui-default/templates/discussion_main_or_node.html b/packages/ui-default/templates/discussion_main_or_node.html
index fa89fdb61..3fe291806 100644
--- a/packages/ui-default/templates/discussion_main_or_node.html
+++ b/packages/ui-default/templates/discussion_main_or_node.html
@@ -15,23 +15,23 @@
     {% set tdoc = vnode %}
     {% set owner_udoc = udict[vnode.owner] %}
     {% include "partials/contest_sidebar.html" %}
-  {% elif vnode.type == model.document.TYPE_DISCUSSION_NODE %}
+  {% else %}
     <div class="section side">
       {% if vnode.pic %}<div class="discussion-node__bg {{ vnode.pic }}"></div>{% endif %}
       <div class="section__header">
         <h1 class="section__title">{{ vnode['title'] or _('Create Discussion') }}</h1>
       </div>
       <div class="section__body">
-      {% if vnode %}
-      {% if handler.user.hasPerm(perm.PERM_CREATE_DISCUSSION) %}
-        <p><a href="{{ url('discussion_create', type=model.discussion.typeDisplay[vnode.type], name=vnode.id) }}" class="expanded primary button">{{ _('Create a Discussion') }}</a></p>
-      {% else %}
-        {% if not handler.user.hasPriv(PRIV.PRIV_USER_PROFILE) %}
-          <p><a href="javascript:showSignInDialog();" class="expanded primary button">{{ _('Login to Create a Discussion') }}</a></p>
+      {% if vnode._id %}
+        {% if handler.user.hasPerm(perm.PERM_CREATE_DISCUSSION) %}
+          <p><a href="{{ url('discussion_create', type=model.discussion.typeDisplay[vnode.type], name=vnode.id) }}" class="expanded primary button">{{ _('Create a Discussion') }}</a></p>
         {% else %}
-          <p><a href="javascript:;" class="disabled expanded primary button">{{ _('No Permission to Create a Discussion') }}</a></p>
+          {% if not handler.user.hasPriv(PRIV.PRIV_USER_PROFILE) %}
+            <p><a href="javascript:showSignInDialog();" class="expanded primary button">{{ _('Login to Create a Discussion') }}</a></p>
+          {% else %}
+            <p><a href="javascript:;" class="disabled expanded primary button">{{ _('No Permission to Create a Discussion') }}</a></p>
+          {% endif %}
         {% endif %}
-      {% endif %}
       {% else %}
         <p>{{ _('Select a node to create discussion.') }}</p>
       {% endif %}