core: bug fix

packages/hydrooj/package.json

@@ -1,6 +1,6 @@
 {
     "name": "hydrooj",
-    "version": "4.17.2",
+    "version": "4.17.3",
     "bin": "bin/hydrooj.js",
     "main": "src/plugin-api",
     "module": "src/plugin-api",

packages/hydrooj/src/handler/home.ts

@@ -368,11 +368,13 @@ function set(s: Setting, key: string, value: any) {
         if (Number.isNaN(+value)) throw new ValidationError(key);
         return +value;
     }
-    if (['json', 'yaml', 'markdown', 'textarea'].includes(s.type)) {
-        if (!Types.Content[1](value)) throw new ValidationError(key);
-    }
-    if (s.type === 'text') {
-        if (!Types.ShortString[1](value)) throw new ValidationError(key);
+    if (value) {
+        if (['json', 'yaml', 'markdown', 'textarea'].includes(s.type)) {
+            if (!Types.Content[1](value)) throw new ValidationError(key);
+        }
+        if (s.type === 'text') {
+            if (!Types.ShortString[1](value)) throw new ValidationError(key);
+        }
     }
     if (s.subType === 'yaml') {
         try {

packages/hydrooj/src/handler/homework.ts

@@ -128,7 +128,7 @@ class HomeworkDetailHandler extends Handler {
         Object.assign(this.response.body, { pdict, psdict, rdict });
     }
 
-    async postAttend(domainId: string) {
+    async postAttend({ domainId }) {
         this.checkPerm(PERM.PERM_ATTEND_HOMEWORK);
         if (contest.isDone(this.tdoc)) throw new HomeworkNotLiveError(this.tdoc.docId);
         await contest.attend(domainId, this.tdoc.docId, this.user._id);